crypto: make pseudoRandomBytes an alias for randomBytes#557
crypto: make pseudoRandomBytes an alias for randomBytes#557calvinmetcalf wants to merge 1 commit intonodejs:v1.xfrom
Conversation
src/node_crypto.cc
Outdated
There was a problem hiding this comment.
Maybe make this const int r = ....
|
LGTM but I would like @indutny to sign off on it as well. |
calvinmetcalf
force-pushed
the
rm-prb
branch
2 times, most recently
from
4fdfcb2 to
a120e87
Compare
|
ok moved the declaration down and made it a const, then split the line so it would pass linting, should an update to the docs be part of the same pull or a separate one? |
There was a problem hiding this comment.
Please don't hate me but it's > 80 columns now.
EDIT: Preempted!
Please roll it into this one. |
|
@bnoordhuis perhaps we should not block in case of pseudo random bytes? |
|
Otherwise I suggest deprecating |
I don't think this PR changes that. Or does it?
I agree but I would suggest doing that in a separate PR, provided we agree this PR is not a functional change. That way, we can land this PR now and land the deprecation PR in 1.1.0. |
|
@bnoordhuis this should not be a functional change @indutny maybe a the blocking/not blocking distinction can be rolled into the changes to the api around randomBytesSync. Will update the docs |
Previously pseudoRandomBytes worked similarly to randomBytes but in the event of insufficient entropy would silently return non-secure values. As of f68a116 the entropy pool blocks if there is insufficient entropy instead of giving an error so there is now no longer a case where pseudoRandomBytes would act differently then randomBytes. Docs are updated to remove pseudoRandomBytes and to clarify that randomBytes now does block instead of erring when entropy is low.
|
updated |
|
LGTM, let's deprecate it soon. |
Previously pseudoRandomBytes worked similarly to randomBytes but in the event of insufficient entropy would silently return non-secure values. As of f68a116, the entropy pool blocks if there is insufficient entropy instead of giving an error so there is now no longer a case where pseudoRandomBytes would act differently than randomBytes. Docs are updated to remove pseudoRandomBytes and to clarify that randomBytes now does block instead of erring when entropy is low. PR-URL: #557 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Fedor Indutny <fedor@indutny.com>
|
Landed with some touch-ups in e5e5980. Thanks, Calvin! |
3 participants
Previously pseudoRandomBytes worked similarly to randomBytes but in the event of
insufficient entropy would silently return non-secure values. As of f68a116
the entropy pool blocks if there is insufficient entropy instead of giving an
error so there is now no longer a case where pseudoRandomBytes would act
differently then randomBytes.
Inspired by discussions on #545